Repository navigation
feat: track incidental findings with explicit follow-up dispositions (#307) - #317
Merged
Merged
Conversation
douglasjarquin
marked this pull request as ready for review
October 18, 2026 04:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #307.
Adds incidental findings: a small, explicitly recorded note for a problem found outside the approved brief. It records a disposition without blocking the original task.
sumctl findingrecords a finding against its originating task and project. Each finding has a stable key, a title and explanation, source and evidence references, and the attempt and candidate when known. Recording never creates a task, a blocking question, or a scope expansion. Repeated submissions with the same key create one record, and conflicting content is refused rather than replacing it.Golden snapshots and help output were regenerated as derived data. No test source was added or changed, per the user's standing rule, so the issue's "focused coverage" item is not done in test code. The
finding.dispositionsfeature-map row says it has no automated coverage and is checked manually.Verification
mise run verifyon 45cdaa2: pass (internal/cli541s).https://claude.ai/code/session_01LmjWPRZjxcGH3kQmkpRToB
Pipeline
mise run lint)Review summary
Review remediation log
Pass 1
Pass 2