Skip to content

feat: track incidental findings with explicit follow-up dispositions (#307) - #317

Merged
douglasjarquin merged 5 commits into
mainfrom
sum/t-fa0e55248f76
Oct 18, 2026
Merged

douglasjarquin merged 5 commits into
mainfrom
sum/t-fa0e55248f76

Conversation

@douglasjarquin

@douglasjarquin douglasjarquin commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

Summary

Closes #307.

Adds incidental findings: a small, explicitly recorded note for a problem found outside the approved brief. It records a disposition without blocking the original task.

  • Recording: sumctl finding records a finding against its originating task and project. Each finding has a stable key, a title and explanation, source and evidence references, and the attempt and candidate when known. Recording never creates a task, a blocking question, or a scope expansion. Repeated submissions with the same key create one record, and conflicting content is refused rather than replacing it.
  • Dispositions: defer, dismiss with a reason, resolve with an outcome, reopen, and promote. Each records the actor, time, reason or outcome, and linked work, and history is preserved.
  • Promotion: links to a new approved task, an existing task, or an existing in-scope repair, and needs the existing coordinator authorization. A linked finding has exactly one target, task or repair, and repeating a promotion does not create duplicate links. A linked handoff stays outstanding until its work or an explicit disposition settles it.
  • Surfaces: unresolved findings appear in inbox, show and context, separately from blocking Needs You decisions. Backups and evidence views include them.
  • Unchanged: review verdicts, PR identity findings and evidence obligations keep their meaning. Legacy notes remain readable.

Golden snapshots and help output were regenerated as derived data. No test source was added or changed, per the user's standing rule, so the issue's "focused coverage" item is not done in test code. The finding.dispositions feature-map row says it has no automated coverage and is checked manually.

Verification

  • Coordinator mise run verify on 45cdaa2: pass (internal/cli 541s).
  • Worker verify runner: pass (run 20261018T024631Z-f778e4c3).
  • Independent review (Codex GPT-6 Luna): approve, after two repair rounds.

https://claude.ai/code/session_01LmjWPRZjxcGH3kQmkpRToB

Pipeline

Generated by sum

Stage Status Result
Intent ✅ Approved brief recorded
Rebase ✅ Up to date with main (main at 6bebf86, observed 2026-10-18T04:22Z)
Review ✅ Passed after 2 remediation passes
Test ✅ Passed; the run certifies no candidate
Document ✅ Passed
Lint ✅ Passed (mise run lint)
Push ✅ Pushed 45cdaa2 to origin/sum/t-fa0e55248f76
PR ✅ Open: #317
CI ➖ No checks reported for this PR (as of 2026-10-18T04:22Z)

Review summary

Review remediation log

Pass 1

  • Limitation: This pass recorded no structured notes.

Pass 2

  • Limitation: This pass recorded no structured notes.

@douglasjarquin
douglasjarquin marked this pull request as ready for review October 18, 2026 04:22
@douglasjarquin douglasjarquin changed the title Factory issue douglasjarquin/sum#307 feat: track incidental findings with explicit follow-up dispositions (#307) Oct 18, 2026
@douglasjarquin
douglasjarquin merged commit 920df23 into main Oct 18, 2026
3 checks passed
@douglasjarquin
douglasjarquin deleted the sum/t-fa0e55248f76 branch October 18, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P2] Track incidental findings through explicit follow-up dispositions

1 participant