Repository navigation
fix: encode optional review-thread line anchors so pr reconcile works (#320) - #321
Merged
Merged
Conversation
douglasjarquin
marked this pull request as ready for review
October 19, 2026 18:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #320.
Since #319,
pr reconcileandsweepfailed withordjson: unsupported type *inton any PR whose review threads are anchored to a code line. The four optional line fields on a review thread (line,original_line,start_line,original_start_line) are now saved as a plain number, ornullwhen absent, so an absent line stays distinct from line 0. Unanchored threads and PRs without threads are unchanged.On 2026-10-19 this failure blocked observation of 29 of the 33 open PRs sum tracks (zumba/salt, security and compliance), and with it every cleanup waiting on those merges.
One file changed (
go/internal/prcmd/threads.go). No test source was added or changed.Verification
mise run verifyon a2c80b1: pass (internal/cli469s).https://claude.ai/code/session_01LmjWPRZjxcGH3kQmkpRToB
Pipeline
mise run lint)Review summary