Skip to content

fix: encode optional review-thread line anchors so pr reconcile works (#320) - #321

Merged
douglasjarquin merged 1 commit into
mainfrom
sum/t-a7de4cb45be7
Oct 19, 2026
Merged

douglasjarquin merged 1 commit into
mainfrom
sum/t-a7de4cb45be7

Conversation

@douglasjarquin

@douglasjarquin douglasjarquin commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

Closes #320.

Since #319, pr reconcile and sweep failed with ordjson: unsupported type *int on any PR whose review threads are anchored to a code line. The four optional line fields on a review thread (line, original_line, start_line, original_start_line) are now saved as a plain number, or null when absent, so an absent line stays distinct from line 0. Unanchored threads and PRs without threads are unchanged.

On 2026-10-19 this failure blocked observation of 29 of the 33 open PRs sum tracks (zumba/salt, security and compliance), and with it every cleanup waiting on those merges.

One file changed (go/internal/prcmd/threads.go). No test source was added or changed.

Verification

  • Coordinator mise run verify on a2c80b1: pass (internal/cli 469s).
  • Worker verify runner: worker run 20261019T155736Z-c90480a3 (pass); before/after CLI evidence for both review-thread scenarios.
  • Independent review (Codex GPT-6 Luna): approve.

https://claude.ai/code/session_01LmjWPRZjxcGH3kQmkpRToB

Pipeline

Generated by sum

Stage Status Result
Intent ✅ Approved brief recorded
Rebase ✅ Up to date with main (main at 44214f0, observed 2026-10-19T18:14Z)
Review ✅ Passed
Test ✅ Passed; the run certifies no candidate
Document ✅ Passed
Lint ✅ Passed (mise run lint)
Push ✅ Pushed a2c80b1 to origin/sum/t-a7de4cb45be7
PR ✅ Open: #321
CI ➖ No checks reported for this PR (as of 2026-10-19T18:14Z)

Review summary

  • Review focus: Nullable line anchors are serialized as integers or null and remain readable through the saved review-thread views.
  • Limitation: Source inspection and recorded replay evidence only; no checks were rerun and no live GitHub query was made.

@douglasjarquin
douglasjarquin marked this pull request as ready for review October 19, 2026 18:14
@douglasjarquin douglasjarquin changed the title Fix douglasjarquin/sum#320 fix: encode optional review-thread line anchors so pr reconcile works (#320) Oct 19, 2026
@douglasjarquin
douglasjarquin merged commit 8783988 into main Oct 19, 2026
3 checks passed
@douglasjarquin
douglasjarquin deleted the sum/t-a7de4cb45be7 branch October 19, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: pr reconcile fails with "ordjson: unsupported type *int" on line-anchored review threads

1 participant