test: stop timer/cache leaks and align queue default - #126
Merged
Merged
Conversation
Install and restore Jest fake timers per test so later suites that need real clocks, such as labelLoader watch, are not poisoned. Co-authored-by: Doug Rathbone <dougrathbone@users.noreply.github.com>
The standalone settings test replaced require.resolve and require.cache without putting them back, which can fail later tests in the same worker. Co-authored-by: Doug Rathbone <dougrathbone@users.noreply.github.com>
ThrottledQueue used a hardcoded 1000 when maxSize was omitted, even though the rest of the bridge reads maxQueueSize from schema. Co-authored-by: Doug Rathbone <dougrathbone@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes three hygiene gaps from the last review: leaked Jest fake timers, ConfigLoader test module-graph mutation, and ThrottledQueue bypassing schema for its default cap. Dependabot #121 is already merged separately.
Changes
Test plan
npm testpasses locally with no failuresnpm run lintpassesnpm run typecheckpassesChecklist
package.jsonandhomeassistant-addon/config.yaml(if releasing)CHANGELOG.mdupdated (if releasing)