Repository navigation
fix: install the newest uploaded C-Gate zip - #149
Merged
Merged
Conversation
Upload mode claimed to follow the newest zip in the share folder, but the lookup was find piped to head, which follows directory order. A second zip dropped in for an upgrade could be ignored, and the one that was installed could change between boots. The newest file is now the one that is installed, with the later name winning when two files share a timestamp. Co-authored-by: Doug Rathbone <dougrathbone@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upload mode installs the newest C-Gate zip in the share folder. The previous lookup followed directory order, so a second zip dropped in for an upgrade could be ignored, and the installed file could change between boots.
Changes
Test plan
npm testpasses locally with no failures (3215 tests)npm run lintpassesnpm run typecheckpassesChecklist
package.jsonandhomeassistant-addon/config.yaml(not releasing in this PR)CHANGELOG.mdupdated (not releasing in this PR)