fix off-by-one over-read of label in rfc822_decode_punycode#292
Open
Usamak06 wants to merge 1 commit into
Open
fix off-by-one over-read of label in rfc822_decode_punycode#292Usamak06 wants to merge 1 commit into
Usamak06 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rfc822_decode_punycode() appends
delim - pos + 1bytes for each label so the trailing '.' gets copied, but for the last label there is no dot and delim equals end, so the +1 reads and appends one byte past the given length (input[len]). The decoded result then carries a stray trailing byte. This copies only the label and appends the '.' separately when delim is still inside the input, which also drops the duplicated append expression. Added a length check to the existing punycode test since str_c() hid the extra byte behind its NUL.