feat: support globs in jsonTrailingCommaFiles - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38
Allows glob patterns in
jsonTrailingCommaFiles:Supported syntax:
*,?,**,[abc]/[a-z]/[!abc], and{a,b}. Patterns match against the end of the file path at a path segment boundary, same as the existing literal entries (ex.tsconfig*.jsonmatches at any depth and.vscode/*.jsonmatches the last two segments).Implementation
dprint uses the
ignorecrate (globset + regex) for its includes/excludes, but this plugin doesn't depend on regex, so pulling it in would bloat the Wasm file. Instead there's a small matcher insrc/glob.rs:*,?, or[) do a single byte comparison against the end of the path without allocating, which is as cheap as the previousends_withchecks.**match trailing path segments without allocating. Globstar patterns use a linear backtracking match over segments, so repeated**can't blow up.trailingCommasisjsonc.Behavior changes
Configuration.json_trailing_comma_filesnow holds normalized patterns (ex."test.json") rather than the doubled"/test.json"and"\test.json"entries. The matcher still handles leading slashes and either separator for anyone constructing the configuration directly.[id].jsonwould need to be written as[[]id].json..., and entries that expand to a./prefix (ex..\a.jsonor{./a.json,b.json}) now report diagnostics.