fix: escape raw control characters in strings - #67
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63
JSON strings can't contain raw control characters (U+0000 through U+001F), but the parser accepts them. The formatter passed them straight to the printer, so a raw newline or tab caused a panic in debug builds and invalid JSON in release builds.
String literals now have these characters escaped.
\n,\r,\t,\band\fget their short forms and everything else becomes\u00XX. This covers single-quoted strings and property names too.Existing escape sequences are left as they are. The parser rejects a backslash followed by a raw control character, so escaping can't change what a string means.
Raw tabs and lone CRs inside strings will now show up as
\t/\rin files that previously formatted without changes.