perf: reduce allocations - #68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces allocations when generating print items and when sorting a
package.json, without changing output.push_strinstead ofpush_string(x.to_string())for strings, property names and numbers, so no throwawayStringis created before dprint-core copies it into its bump allocator.true,false,nulland,usesc!string containers, so their width is computed at compile time and nothing is allocated per value.ExactSizeIteratorinstead of collecting aVec<Option<Node>>for every array and object. TheNonecase was never used.package.jsonsorting usesPropertySort::by_key, which caches keys, instead of comparators that decoded both property names intoStrings on every comparison..jsoncextension check useseq_ignore_ascii_caseinstead of allocating a lowercased string.Benchmark
Median of 15 runs, comparing
mainagainst this branch; the output is asserted identical.On the large file most of the time is spent in dprint-core's printer (~65%) and in parsing, so the allocation drop doesn't show up as a measurable speedup there.