Skip to content

feat: add targetVersion and known module import classification options - #23

Open
apcamargo wants to merge 1 commit into
dprint:mainfrom
apcamargo:extra-settings
Open

apcamargo wants to merge 1 commit into
dprint:mainfrom
apcamargo:extra-settings

Conversation

@apcamargo

Copy link
Copy Markdown
Contributor

This PR introduces three new options:

  • targetVersion (e.g.: "py312" or "default") sets the Python version the code targets. Formatting and import sorting then follow that version.
  • knownFirstParty and knownThirdParty control which section imports sort into. This is important because the dprint plugin does not perform automatic identification of first-party modules like ruff does, so we should allow the user to at least input that manually.

This is a follow up to #22

This PR is AI-assisted, but I did perform a couple of reviews and could not find any issue.

@apcamargo

Copy link
Copy Markdown
Contributor Author

@dsherret ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant