feat: implement pluggable runtimes - #142
Open
dungdm93 wants to merge 24 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements Pluggable Runtimes (OCI container images as plugins, e.g.
drassi/node:24,drassi/python:3.12) in Drassi across Host, Incus, and Container/Docker sandboxers.Key Changes
Runtime Configuration (
core/config):config.Runtimeoptions (image, alias, subpath, executable, cmd, paths).configusingconfig.RegisterSandboxerfactory registry to avoid import cycles.Provisioning Engine (
core/pkg/runtime/provision):provision.Contextwith Go 1.27 generic methods (Set[T],Get[T],MustGet[T]) andStateKey[T].provision.Operationinterface (PreLaunch,PostLaunch) andprovision.Pipeline.provision.Pull,provision.Mount, andprovision.ConfigurePathEnv.Storage Management (
core/pkg/runtime/storage):storage.Managerencapsulatinggo.podman.io/storageandgo.podman.io/image/v5.Runtime Registry (
core/pkg/runtime):runtime.Registrywith direct and alias lookup (e.g.,node20,node22->node).runtime.Runtimewith command templating ({0}substitution with script paths).Sandboxer Integration:
host.Symlinkoperation for symlinking mounted runtime trees into the host layout.incus.DiskDeviceoperation for host-to-container disk device mappings.container.BindMountandcontainer.ImageMountoperations for container spec mounts.Action Executor & DI Wiring:
nodeActionExecutorinaction_node.goto resolve its runtime in theinitphase via DI without touchingaction_script.go.runtime.Registryincore/wire/runtime/module.go.Verification
core,runner-gha, andrunner-gitea.