Skip to content

[core/gitstore] refactor Manager methods to use Option pattern - #146

Merged
dungdm93 merged 1 commit into
mainfrom
gitstore-options
Sep 9, 2026
Merged

[core/gitstore] refactor Manager methods to use Option pattern#146
dungdm93 merged 1 commit into
mainfrom
gitstore-options

Conversation

@dungdm93

@dungdm93 dungdm93 commented Sep 9, 2026

Copy link
Copy Markdown
Member

Description

  • Move authentication token in gitstore.Manager.Fetch into FetchOption (WithToken).
  • Merge File and Read methods into a single Read method using ReadOption (WithSubpath, WithFile).
  • Separate readFile and readArchive internal helper methods in manager.go.
  • Return an error if both file and subpath are specified in ReadOption.
  • Update all callers and unit tests to match the new API.

@dungdm93
dungdm93 merged commit 0537903 into main Sep 9, 2026
2 checks passed
@dungdm93
dungdm93 deleted the gitstore-options branch September 9, 2026 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant