Repository navigation
feat(site): literary Reader design and searchable evidence gallery - #291
Merged
Merged
Conversation
Raise light-theme border contrast above 3:1 against both adjoining surfaces, with a regression for non-text control boundaries. Refs #283.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-visible delivery
Refs #283; intentionally does not close its full browser/accessibility acceptance gate.
Exact branch changes
Base: master
5c03ee428df6cc36ebdeff2443d35ac9f7e72dca.New commits:
ef79a8a,e34f28f,cf4d0e5, and CI repairsa285f90,d3911c6atop literary-theme commit199d1c0.Files:
scriptorium/site_renderer.py,scriptorium/site_gallery_filter.py,tests/test_site_literary_theme.py,tests/test_site_gallery_filter.py, existing changelog fragment.Verification and release boundary
d3911c62c41a3e139585f8b38b67358048cf462f: 6/6 SUCCESS; Pages suite 783/783 PASS, deterministic canonical build/rebuild PASS, Reader installed-wheel workflow PASS. Initial CI failures were fixed without reducing no-inline-script or keyboard-focus security/accessibility requirements.12479254589from Pages workflow inspected locally: 7 HTML routes, 31 resolved internal links/assets, single allow-listed homepage JS asset, Node syntax PASS. Both derived comparison JSON/CSV exports are byte-identical to prior PR Reader 0.4: private comparison, trustworthy evidence and installed-package delivery #288 Pages artifact12407216390. Chromium rendering/interaction of the exact CI-produced HTML/CSS/JS in about:blank: desktop 1440 and mobile 390 light/dark all PASS (search, 2/2/2 filters, reset/focus, no overflow, no external requests, no-JS fallback). Directfile://browser navigation was blocked (ERR_BLOCKED_BY_ADMINISTRATOR): VISUAL_NOT_VERIFIED for real local/Pages route; NOT_LIVE_VERIFIED.Authored in this run: do not self-approve or merge in the authoring run.