Repository navigation
chore: release - #209
Closed
github-actions[bot] wants to merge 1 commit into
Closed
chore: release#209github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
审查结论(PR #209 / head 876333a)
变更内容
release-plz 自动发布 PR(chore: release),仅 5 个文件、+16/-4:
httpboot-protocol/Cargo.toml0.5.0→0.5.1,ostool-serial/Cargo.toml0.1.0→0.1.1- 两个 crate 的
CHANGELOG.md各新增对应发布段落;Cargo.lock同步这两处版本号
无 Rust 源码、API、配置格式或工作流改动。
影响面
- 版本提升为 patch 级且语义兼容(release-plz 报
✓ API compatible changes)。根Cargo.toml:27,29的 workspace 依赖使用 caret 约束httpboot-protocol = { version = "0.5", … }、ostool-serial = { version = "0.1", … },0.5.1 / 0.1.1 仍在其兼容区间内,无需调整依赖声明。 - 已逐项核对锁文件一致性:
Cargo.lock中httpboot-protocol= 0.5.1、ostool-serial= 0.1.1,ostool0.31.0 与ostool-server0.9.0 的依赖项以包名引用,没有残留 0.5.0/0.1.0 或造成版本歧义的重复包条目,未发现清单与锁文件不一致。 - 变更完全隔离:不触及 QEMU、串口、TFTP、U-Boot、电源等操作敏感路径,也不改变已有公开 API 或数据格式;下游(如 TGOS)锁文件不会被强制升级。
CI 与本地验证
- head 提交的 check-runs 为 0、combined status 为
pending(GET /commits/876333a…/check-runs、GET /commits/876333a…/status),当前没有可判定的 CI 结论,也没有由本 PR 引起的失败检查。 - 本审查环境没有 Rust 工具链(
command -v cargo→ not found),因此 review helper 建议的cargo fmt --check、cargo clippy … -D warnings、cargo test -p httpboot-protocol -p ostool-serial均未执行,也无法运行cargo metadata --locked;本次以静态核验(Cargo.toml ↔ Cargo.lock ↔ CHANGELOG 三者一致)替代,并明确记录未运行的检查。由于 diff 不含 Rust 源码,CI 回归风险极低。
历史意见与相似 PR
- 本 PR 没有任何既有 review 或 issue 评论(
GET /pulls/209/reviews返回空、comments=0),无需跟进的遗留意见。 - 相似 release PR 均采用同一模式并被直接合并(#208、#200、#204),本轮未发现针对同一版本的重复或冲突发布 PR(#202、#181 是上一轮被新 PR 取代后关闭的)。
未解决项(两项均为非阻塞建议)
- 文档版本号滞后:
docs/axloader-serial-ownership.md:111与docs/axloader-network-control.md:175-176仍把对外交付版本写为httpboot-protocol 0.5.0/ostool-serial 0.1.0,而本 PR 合并后会把两者分别发布为 0.5.1 / 0.1.1,却未同步 docs(AGENTS.md 要求用户可见文档随契约/工作流变化同步)。建议在本 PR 内更新这两处版本号,或注明 0.5.1/0.1.1 仅为 release-plz 补发、对外基线仍为 0.5.0/0.1.0。相关文件不在本次 diff 内,故只能以正文形式给出。 - PR 描述与 diff 不符:描述列出
ostool: 0.30.3 -> 0.31.0与ostool-server: 0.8.2 -> 0.9.0,但这两个升级已由 base 提交 787943d(#208) 完成并已打标(ostool-v0.31.0、ostool-server-v0.9.0均存在),本 PR diff 不含它们。建议更正描述,避免误判本次发布范围。
补充核对:新增 CHANGELOG 段落只含 ### Other + - release ([#208])(即零功能变更的 patch 补发)。该形态在本仓库历史中多次出现(httpboot-protocol 0.4.1、0.2.1 段落同样如此),属 release-plz 的既有行为而非本次引入,不作为问题提交。
结论
未发现阻塞问题,本 PR 可安全合并;上述两项仅为文档与描述层面的非阻塞建议。因只有 advisory 级观察项,本次以 COMMENT 提交。
Powered by deepseek-flash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 New release
httpboot-protocol: 0.5.0 -> 0.5.1 (✓ API compatible changes)ostool-serial: 0.1.0 -> 0.1.1 (✓ API compatible changes)ostool: 0.30.3 -> 0.31.0ostool-server: 0.8.2 -> 0.9.0Changelog
httpboot-protocolostool-serialostoolostool-serverThis PR was generated with release-plz.