Skip to content

Fix unclosed table call in SingleStore schema examples - #696

Open
meliharik wants to merge 1 commit into
drizzle-team:mainfrom
meliharik:fix-singlestore-schema-examples
Open

Fix unclosed table call in SingleStore schema examples#696
meliharik wants to merge 1 commit into
drizzle-team:mainfrom
meliharik:fix-singlestore-schema-examples

Conversation

@meliharik

Copy link
Copy Markdown

The SingleStore schema example closes singlestoreTable(...) with }; instead of });, so the call is never closed. It appears in three files:

  • singlestore/drizzle-kit-generate.mdx:41
  • singlestore/drizzle-kit-push.mdx:43
  • singlestore/drizzle-kit-pull.mdx:52
 export const users = p.singlestoreTable("users", {
   id: p.int().primaryKey().autoincrement(),
   name: p.varchar({ length: 255 }),
   email: p.varchar({ length: 255 }).unique(),
-};
+});

The MySQL versions of the same three pages have the identical snippet with }); at the same line, so this looks like it was missed when the SingleStore pages were derived from them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant