Rework UnaryOpNode - #627
Draft
arcondello wants to merge 2 commits into
Draft
Conversation
arcondello
force-pushed
the
feature/unaryop-rework
branch
2 times, most recently
from
August 27, 2026 20:31
c5d1e4b to
ab1eb6a
Compare
arcondello
force-pushed
the
feature/unaryop-rework
branch
from
August 27, 2026 20:41
ab1eb6a to
1d53fd1
Compare
arcondello
commented
Aug 27, 2026
| auto p_ptr = graph.emplace_node<UnaryOpNode<TestType>>(a_ptr); | ||
| auto* p_ptr = graph.emplace_node<UnaryOpNode<TestType>>(a_ptr); | ||
|
|
||
| graph.emplace_node<ArrayValidationNode>(p_ptr); |
Member
Author
There was a problem hiding this comment.
This test was modified more than the others as part of fixing a bug. I figure the changes are for the better but are not so important that we need to propagate them to all other tests.
arcondello
commented
Aug 27, 2026
| using LogicalNode = UnaryOpNode<functional::logical>; | ||
| extern template class UnaryOpNode<functional::logical>; | ||
|
|
||
| using NegativeNode = UnaryOpNode<functional::negate>; |
Member
Author
There was a problem hiding this comment.
I think now that these are all ops we define rather than std:: ones, we should rename them to be consistent with the nodes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very much a work in progress. But putting it up so folks can see how #626 is intended to be used.
AI Generation Disclosure
Claude helped a lot with this one. Mostly by catching edge cases in the funcs, implementing a few of them once I showed it the pattern (e.g.,
rint) and by helping to write the tests. In the end, most of the code was actually written by me once I made all the changes I wanted.The changes to
UnaryOpNodedidn't use any AI.