Conversation
timeout or default treated 0 as missing and posted 300 seconds. JS uses ?? and keeps 0. Fork already used if timeout is not None.
🦋 Changeset detectedLatest commit: 0a0e268 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
TASTE.md review: checked T-1/T-2 (JS↔sync↔async parity — the is not None default now matches JS timeoutMs ?? default and the existing fork handling, applied identically in sandbox_sync and sandbox_async), T-44/T-47 (sandbox-lifetime clock, default via the named default_sandbox_timeout constant, no magic numbers), T-52 (no client-side rejection of timeout <= 0 — left to the backend). 0 violations; the change complies with TASTE.md.
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
I believe this is on purpose, keep in mind also that we will be dropping all the SDK defaults from the SDK in favor of backend-defined values: |
|
You're right. |
Fixes #1840
Sandbox.create(timeout=0)andSandbox.connect(..., timeout=0)usedtimeout or default, so 0 became 300 seconds. JS create usestimeoutMs ?? defaultand keeps 0. Fork already usedif timeout is not None.Same
if timeout is not Nonedefault in sync and async_createand_cls_connect. I did not rejecttimeout <= 0. JS sends 0.Testing (no live API):
6 passed. Restoring the four
ordefaults makes the fourtimeout=0cases fail with posted timeout 300 instead of 0.