Skip to content

Format, lint on PR, require all changes be committed - #228

Closed
djeebus wants to merge 6 commits into
mainfrom
linters
Closed

djeebus wants to merge 6 commits into
mainfrom
linters

Conversation

@djeebus

@djeebus djeebus commented Feb 2, 2026 •

Copy link
Copy Markdown

I noticed that PRs occasionally fight over single vs double quotes, so I added this to keep it consistent and reduce the noise.


Note

Low Risk
Primarily CI/tooling and mechanical formatting changes; main risk is CI becoming stricter and failing existing PRs until formatting/lint fixes are committed.

Overview
CI now enforces formatting/lint correctness in PRs. A new lint job runs bun run format, bun run lint:fix, and bun run lint, then fails if those steps modify tracked source files (excluding bun.lock).

Tooling/version alignment: CI now derives the Bun version from a new .tool-versions file via wistia/parse-tool-versions, and package.json switches lint/lint:fix from next lint to eslint (with eslint.config.mjs updated to ignore .next/).

Repo-wide formatting churn: large mechanical reformatting (quotes/line wraps) across TS/TSX, OpenAPI specs, and generated type files, plus bun.lock updates including file-type and related deps.

Written by Cursor Bugbot for commit 5ed0a24. This will update automatically on new commits. Configure here.

@vercel

vercel Bot commented Feb 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment Feb 4, 2026 0:57am
web-juliett Ready Ready Preview, Comment Feb 4, 2026 0:57am

Request Review

@vercel
vercel Bot temporarily deployed to Preview – web February 2, 2026 18:13 Inactive
@ben-fornefeld ben-fornefeld added improvement Improvements in-code labels Feb 4, 2026
@vercel
vercel Bot temporarily deployed to Preview – web February 4, 2026 00:31 Inactive
@vercel
vercel Bot temporarily deployed to Preview – web February 4, 2026 00:39 Inactive
@vercel
vercel Bot temporarily deployed to Preview – web February 4, 2026 00:50 Inactive
@vercel
vercel Bot temporarily deployed to Preview – web February 4, 2026 00:56 Inactive
@ben-fornefeld

Copy link
Copy Markdown
Member

Thanks for the PR. I am planning to migrate from prettier / eslint to biome for some time already. I would create a new PR for the migration and merge your workflows into that one

@ben-fornefeld
ben-fornefeld marked this pull request as draft February 25, 2026 01:16
@ben-fornefeld

Copy link
Copy Markdown
Member

closing in favor of #247

This branch was previously deployed

1 inactive deployment
Preview – web — 5ed0a242 Deployed Feb 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvements in-code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants