Repository navigation
Default to Yes when exporting a callsign KLog considers invalid - #1139
Merged
Merged
Conversation
showInvalidCallMessage() asks whether to export a callsign the validator rejected, with No as the default button. Since the dialog itself says the call may well be valid and wrongly flagged, defaulting to No means an accidental Enter or Escape silently drops a real QSO from the export. The QSO stays in the log and is marked as sent, so nothing looks wrong, but it never reaches LoTW or Club Log. I found this when my log showed one QSO more than the exported ADIF. Example: 4JT3DJ (Azerbaijan), 35,245 lookups on QRZ, QSL via Club Log OQRS and the bureau: https://www.qrz.com/db/4JT3DJ Defaulting to Yes keeps the warning but makes the safe answer the default one.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
showInvalidCallMessage() asks whether to export a callsign the validator rejected, with No as the default button. Since the dialog itself says the call may well be valid and wrongly flagged, defaulting to No means an accidental Enter or Escape silently drops a real QSO from the export.
The QSO stays in the log and is marked as sent, so nothing looks wrong, but it never reaches LoTW or Club Log. I found this when my log showed one QSO more than the exported ADIF.
Example: 4JT3DJ (Azerbaijan), 35,245 lookups on QRZ, QSL via Club Log
OQRS and the bureau: https://www.qrz.com/db/4JT3DJ
Defaulting to Yes keeps the warning but makes the safe answer the default one.