Repository navigation
Do not tell the user TQSL succeeded when it may have failed - #1140
Merged
Merged
Conversation
When LoTW is unreachable, TQSL shows the error in its own window and still exits with code 0, printing nothing to stdout. KLog then reports 'TQSL finished with no error' and offers to mark the QSOs as sent, with Yes as the default button. The QSOs then carry lotw_qsl_sent='Y' while LoTW never received them. Nothing looks wrong, and they are excluded from every later upload, so they are silently lost. Reproduced by pointing lotw.arrl.org at 127.0.0.1: TQSL reported 'Unable to upload - either your Internet connection is down or LoTW is unreachable', and KLog still reported no error. Since TQSL's result cannot be trusted here, this asks the user what TQSL actually reported and defaults to No.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When LoTW is unreachable, TQSL shows the error in its own window and still exits with code 0, printing nothing to stdout. KLog then reports 'TQSL finished with no error' and offers to mark the QSOs as sent, with Yes as the default button.
The QSOs then carry lotw_qsl_sent='Y' while LoTW never received them. Nothing looks wrong, and they are excluded from every later upload, so they are silently lost.
Reproduced by pointing lotw.arrl.org at 127.0.0.1: TQSL reported 'Unable to upload - either your Internet connection is down or LoTW is unreachable', and KLog still reported no error.
Since TQSL's result cannot be trusted here, this asks the user what TQSL actually reported and defaults to No.