Skip to content

fix(write-to-file): run diff cleanup when handleError rejects (split 5/6 of #1066) - #68

Closed
easonLiangWorldedtech wants to merge 1 commit into
p1066/u3-parse-failure-boundaryfrom
p1066/u6-execute-error-path-cleanup
Closed

easonLiangWorldedtech wants to merge 1 commit into
p1066/u3-parse-failure-boundaryfrom
p1066/u6-execute-error-path-cleanup

Conversation

@easonLiangWorldedtech

Copy link
Copy Markdown
Owner

U6 — execute() error-path cleanup invariant

Part of the PR Zoo-Code-Org#1066 split (tracking issue Zoo-Code-Org#703) split (content source of record: 72143527fd33306e5541116093c2cbf803cce9e0..pr-1066-audit).

Why this unit exists: execute() cleanup invariant: the finally around handleError, the writeApproved flag and the consecutive-mistake-counter order. Soft budget overshoot: 439 a+d (single provider group, single gate scope).

Boundaries

  • base: e2a03d949257
  • head: 03bde6705ef6
  • content source: 72143527fd33306e5541116093c2cbf803cce9e0..pr-1066-audit (local)

Fidelity (machine-verified)

zdt split verify --contract U6.json --worktree <wt> --head 03bde6705ef6

Result: PASS — standalone 439 a+d / 2 files (SOFT-OVERSHOOT (rationale required in PR body))

  • src/core/tools/WriteToFileTool.ts: OK (content subset of source)
  • src/core/tools/__tests__/writeToFileTool.spec.ts: OK (content subset of source)

Budget rationale (soft overshoot): see the deviations list

Design contract

Verification (this unit, as pushed)

  • Tests: 259 passed / 5 skipped
  • changed-line coverage: 14 covered / 0 uncovered — PASS
  • ESLint: clean on every touched file; suppression counts unchanged
  • No .changeset file, no CHANGELOG edit.

Recreate policy

If the bot stalls on a pre-merge check and the existing head cannot obtain bot review/approval (empty-commit re-trigger attempted and failed), the unit is recreated from the tagged content source of record — never from a per-PR head. At most 1 PR per issue.

@easonLiangWorldedtech

Copy link
Copy Markdown
Owner Author

Moved to the upstream repo (base = main); the split chain is tracked in Zoo-Code-Org#703.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant