Repository navigation
Compare object keys in TypeScript test helper - #872
Merged
Merged
Conversation
By mistake, ``checkJsonablesEqual`` in the generated TypeScript tests collected the keys of the obtained object from the expected one (``Object.keys(expected).filter(...)``), so an extra key in the output went unnoticed. We collect them now from ``Object.keys(got)``, and report a ``null`` or a non-object where an object or an iterable was expected, instead of throwing.
Coverage Report for CI Build 41066892281Coverage remained the same at 90.233%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By mistake,
checkJsonablesEqualin the generated TypeScript tests collected the keys of the obtained object from the expected one (Object.keys(expected).filter(...)), so an extra key in the output went unnoticed. We collect them now fromObject.keys(got), and report anullor a non-object where an object or an iterable was expected, instead of throwing.