Repository navigation
adapter.json, adapter.xml: Retain falsy Extension and Qualifier values - #683
Open
LivingLikeKrillin wants to merge 1 commit into
Open
LivingLikeKrillin wants to merge 1 commit into
LivingLikeKrillin wants to merge 1 commit into
Conversation
Extension and Qualifier values are currently written only if truthy,
so 0, Decimal("0"), and False are dropped and read back as None.
They are now written whenever not None so that they survive a
write/read round trip.
Fixes eclipse-basyx#682
Signed-off-by: Jooyoung Jung <livinglikekrillin@gmail.com>
Assisted-by: Anthropic Claude Opus 5.5 (claude-opus-5-5)
LivingLikeKrillin
force-pushed
the
fix/zero-extension-qualifier-value
branch
from
October 31, 2026 00:33
9dc44e3 to
486b6fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON and XML serializers previously wrote an
ExtensionorQualifiervalue only if it evaluated to truthy. Consequently,0,Decimal("0"), andFalsewere dropped and read back asNone.The serializers now check that the value is not
None, matchingProperty. Falsy values are therefore preserved, and round-trip tests for both the JSON and XML adapters verify that0,Decimal("0"), andFalsedeserialize correctly.Fixes #682
Testing
python -m unittestin sdk: 274 tests OK (8 skipped: no CouchDB / schema files locally).mypy basyx test: no issues.ruff check: all checks passed.🤖 Generated with Claude Code