Refactor OnProxyMethodUnsubscribe to remove code duplication - #1058
Merged
bemerybmw merged 2 commits intoSep 9, 2026
Conversation
Tejveerpratap2803
force-pushed
the
tepr_refactor_OnProxyMethodUnsubscribeFinished_func
branch
from
September 8, 2026 11:14
6e4b677 to
7fc673f
Compare
Tejveerpratap2803
changed the title
Tejveerpratap2803
marked this pull request as ready for review
September 8, 2026 11:20
Tejveerpratap2803
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
September 8, 2026 11:20
Tejveerpratap2803
force-pushed
the
tepr_refactor_OnProxyMethodUnsubscribeFinished_func
branch
4 times, most recently
from
September 8, 2026 12:12
00e5a8d to
efdaf28
Compare
Tejveerpratap2803
marked this pull request as draft
September 8, 2026 12:13
sahithi-nukala
added
test-qnx
Tejveerpratap2803
force-pushed
the
tepr_refactor_OnProxyMethodUnsubscribeFinished_func
branch
from
September 8, 2026 13:22
efdaf28 to
52231ee
Compare
- Merged OnProxyMethodUnsubscribe and OnProxyMethodUnsubscribeFinished into a single OnProxyMethodUnsubscribe method. - Returns bool and assert/ignore decided at call site. - Added doc comment and call site comments. - Renamed test fixtures/cases to match.
Tejveerpratap2803
force-pushed
the
tepr_refactor_OnProxyMethodUnsubscribeFinished_func
branch
from
September 9, 2026 03:35
52231ee to
35f3b48
Compare
Tejveerpratap2803
marked this pull request as ready for review
September 9, 2026 07:01
bemerybmw
requested changes
Sep 9, 2026
bemerybmw
requested changes
Sep 9, 2026
Tejveerpratap2803
force-pushed
the
tepr_refactor_OnProxyMethodUnsubscribeFinished_func
branch
from
September 9, 2026 12:32
eb492d6 to
964ee46
Compare
Tejveerpratap2803
force-pushed
the
tepr_refactor_OnProxyMethodUnsubscribeFinished_func
branch
from
September 9, 2026 12:33
964ee46 to
3ac0858
Compare
bemerybmw
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor OnProxyMethodUnsubscribe to remove code duplication