Repository navigation
Corect lockfile generation - #78
Merged
pawelrutkaq merged 2 commits intoOct 6, 2026
Merged
Conversation
|
The created documentation from the pull request is available at: docu-html |
The patch labels are hashed into the crate_universe digest in Cargo.Bazel.lock. '//patches:...' renders differently when score_crates is the root module and when it is a dependency, so one lockfile could only match one of them. Hard-code the canonical label so the committed Cargo.Bazel.lock is valid for root and for consumers. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Author
|
This is kind of workaround, to be revised with rules_rust 0.71+ |
arkjedrz
requested changes
Oct 6, 2026
| crate.annotation( | ||
| crate = "iceoryx2-bb-derive-macros-qnx8", | ||
| patches = ["//patches:iceoryx2_bb_derive_macros_readme.patch"], | ||
| # The label is hard-coded to the canonical repo name on purpose: the patch labels are part of the |
Contributor
There was a problem hiding this comment.
Rewrite to humanese?
Canonical repo name must be used to ensure lockfile match.?
Contributor
Author
There was a problem hiding this comment.
this is right bazel nomenclature ;]
Contributor
There was a problem hiding this comment.
Soft disagree, but won't block on that.
arkjedrz
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch files need to "pretend" its path as external module to allow correct lock file generation.
Closes #75