Conversation
|
| Name | Type |
|---|---|
| @eddeee888/gcg-typescript-resolver-files | Minor |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
eddeee888
marked this pull request as ready for review
September 22, 2026 13:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR locks in the #455 fix behaviourally: it adds two adjacent schema types to the
test-mappers-vs-schema-types-advancede2e suite — one whose mapper points at an unresolvable import, one whose mapper is genuinely{}— so the committed generated output itself proves the two cases are now treated differently.tsconfig, which is exactly what the e2e suite does.Promise<void>stubs whenever a mapper's import wasn't generated yet (e.g. a Prisma client on a fresh checkout).What
schema.graphqls: addsMappedResolveErrorandMappedResolveEmptyObject, each withid: ID!andfield: String!.schema.mappers.ts:MappedResolveErrorMapperis re-exported from'does-not-exist'(unresolvable → TS error type);MappedResolveEmptyObjectMapper = {}(genuinely empty).MappedResolveError.tscarries no field stubs, whileMappedResolveEmptyObject.tsstill stubs bothidandfield— the exact distinction #455 introduced..changeset/tricky-mappers-warn.md:patch→minor, since skipping stub generation changes generation behaviour for existing configs.Verification
typescript-resolver-files-e2eis marked affected for this PR in.github/workflows/ci.yml, so the two new generated resolver files are checked in CI rather than merely committed.typescript-resolver-files-e2esits in the changesetsignorelist, and the changeset bot confirms a single minor bump for@eddeee888/gcg-typescript-resolver-files.Resources