Release to staging: strict push_to_dds argument checks and clearer call errors (ref #306883) - #79
Merged
Merged
Conversation
Release 0.1.20: SDI metadata extraction, %sdi and %metadata magics (ref #306883)
Release 0.1.21: catalog/storage paths and Dremio catalog check in %metadata
Release 0.1.22: target_name for push_to_dds (ref #306883)
Sync main back into development (v0.1.22)
…f #306883 - target_name must be a str file name: an SdiMetadata passed there raises with a hint to use metadata=; empty names, paths and characters no file system accepts (< > : " | ? * and control characters) raise ValueError. - %metadata push_to_dds validates its arguments before looking up any DDS or Dremio settings, so the error names the bad argument. - metadata_path accepts the record in place of its UUID; a non-str uuid raises TypeError. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Redmine-Hook: v1
…306883 - push_to_dds (session and controller) checks every argument's type in parameter order, positional or named: str/bool parameters take nothing else, and the message names the argument and its position. - A call that doesn't fit the signature (unknown keyword, an argument given twice, too many arguments) reports why plus the correct form of the call. - A magic line that isn't valid Python (e.g. an unnamed argument after a name=value one) names the offending argument, suggests parameters its value fits, and shows the usage, for every magic. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Redmine-Hook: v1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes
developmenttostaging. Ref #306883.What's in it
target_namemust be a valid file name (0d55474).str. AnSdiMetadatapassed there gets a hint to usemetadata=.< > : " | ? *, control characters) are rejected.%metadata push_to_ddschecks its arguments before looking up any DDS or Dremio settings.push_to_dds(36e14dc).strandboolparameters take nothing else, and the message names the argument and its position, e.g.argument 5 (force) must be bool, not int.usage:line.push_to_dds(DDS_PATH, metadata=metadata, True), names the unnamed argument, suggests parameters its value fits (force=True or check_catalog=True), and shows the usage. This applies to every magic.main(Sync main back into development (v0.1.22) #78), which are already ondevelopment.Tests
503 passed, 1 skipped (the live SDI test).
🤖 Generated with Claude Code