Add rigorous review and notification policy harness - #1
Draft
samrathchadha wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds organization-wide contribution instructions, a default PR template, three read-only review agents, and a reusable deterministic PR evidence gate. It also stages a least-privilege GitHub-to-Slack design: event/channel matrix, read-only GitHub App and one-scope Slack manifests, exact authorization runbook, strict normalized-event schema, and a transport-free Slack renderer.
Why
Recent PRs frequently state validation or empirical conclusions without a consistent claim/evidence boundary. A reviewer should be able to see what was observed, what was inferred, and how to reproduce a result without reading agent transcripts. Engineering notifications need the same boundary so Slack does not become a noisy transcript feed or leak PR bodies, logs, prompts, or credentials.
Evidence
tests/test_slack_notification_contract.py/agentslocationchat:writedocs/integrations/slack/README.mdValidation
python3 -m py_compile scripts/pr_evidence_gate.py scripts/slack_notification_contract.py;python3 -m unittest discover -s tests -v;python3 -m json.tool docs/integrations/slack/github-app-manifest.template.json;python3 -m json.tool docs/integrations/slack/normalized-event.schema.json;python3 -m json.tool docs/integrations/slack/normalized-event.example.json;ruby -e 'require "yaml"; YAML.safe_load(File.read("docs/integrations/slack/slack-app-manifest.yaml"), aliases: false)';git diff --check27b8e560cb36ffe1f428100aad710d4d77cee17b.Risks and limitations
The deterministic gates check required structure and obvious unsafe shapes, not truth. Keyword-based research detection can produce false positives, and PR authors can mislabel work as not result-bearing. Agent reviews are non-deterministic and remain advisory. A complete message contract can still contain a false human-authored statement. GitHub Projects webhooks are public preview. The Slack/GitHub manifests are review templates, not proof that an undeployed broker is secure. The shared workflow must be pinned by full SHA from caller repositories.
Non-goals
This PR does not enable paid AI services, install Slack or GitHub Apps, grant OAuth, create tokens or webhooks, store secrets, send Slack messages, deploy the broker, alter repository protections, run product tests, post review comments, or merge any existing PR.
Reproducibility
Result-bearing: no — this is policy and tooling work, not an empirical result.
AI assistance
Codex drafted and locally validated the policy/tooling. A human must review the policy, app permissions, authorization screens, message/data boundary, false-positive profile, and measured rollout before merge or installation.