Repository navigation
docs: close spec gaps (#45/#46) and correct WHITEOUT's Sepolia status (#44) - #53
Merged
Merged
Conversation
specs/02 listed four anchor-name reject rules, but EFSIndexer._isValidAnchorName also rejects a needless escape such as %41 for "A". A client built from the prose alone (or on encodeURIComponent) would mint names the resolver reverts. Add the fifth rule, and note that NFC is checked on the decoded name. specs/09 left two choices implicit that the SDK's conformant reader had to make. Pin both to what the section 8 pseudocode already does: the lowest-UID tie-break picks from all of an attester's redirects of any kind, and D_MAX bounds one follower walk, not the whole path. Add conformance vectors 13 and 14 for them. Several docs called WHITEOUT "live" or "shipped". A Sepolia readback (block 12007898) shows it is implemented in source only: no code at the Safe-keyed CREATE3 address (the same derivation reproduces EdgeResolver's address), no registered schema at the UID that deploy would produce, and whiteoutResolver() reverts on every live router and file view. Record that in CHAINS.md and make the current-state docs say so. ADR bodies stay unedited; ADR-0055 and ADR-0067 get Status-line notes per the docs/adr/README.md amendment pattern. Docs only. No contract, schema, deploy, or client behavior changes. Fixes: #44, #45, #46 Permanence-tier: Durable Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Specs and ADRs described the indexer on main as current, but the live Sepolia EFSIndexer proxy still runs the freeze-time implementation: MAX_ANCHOR_DEPTH() returns 32 (main: 256, ADR-0068), and index() still propagates folder presence (main: discovery-only, ADR-0066). The upgrade carrying both was merged on 2026-06-23/25 but never executed. These are the only two indexer changes since the freeze. Add the readback to CHAINS.md (with the storage-layout and ordering notes the eventual upgrade needs: indexer before WHITEOUT, or index() on a WHITEOUT could mark a folder present), and chain-qualify specs/03, FUTURE_WORK and the ADR-0066/0068 Status lines. Docs only. Refs: #44 Permanence-tier: Durable Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
JamesCarnley
added a commit
that referenced
this pull request
Nov 12, 2026
Resolve the two overlaps with #53: keep both new decisions.md entries, and in specs/overview.md read-flow keep this branch's step 3 (segment re-encoding) with main's step 4 (WHITEOUT terminal not yet live on Sepolia). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
%41forA), plus a note that NFC is checked on the decoded name, not the escaped string.D_MAXbounds one follower walk, not the whole path (§3). Adds conformance vectors 13 and 14.docs/CHAINS.md. ADR-0055/0067 get Status-line notes only; their bodies are unedited.MAX_ANCHOR_DEPTH()returns 32 (main: 256), andindex()still propagates folder presence (main: discovery-only).CHAINS.mdrecords the readback; specs/03, FUTURE_WORK and the ADR-0066/0068 Status lines are chain-qualified. It also records that the indexer must be upgraded before WHITEOUT is deployed.Why
v1 stays live on Sepolia with no v2 date, so its specs have to match the deployed contracts.
encodeURIComponent) mints namesEFSIndexerreverts.Sepolia readback (block 12007898):
WhiteoutResolverSafe-keyed CREATE3 address0xE007…eBFa(same derivation reproduces EdgeResolver's0xD664…7F1)getSchema(0xfccc…541d)(the UID that deploy would register; formula checked against DATA's UID)whiteoutResolver()on the current and previous EFSRouter / EFSFileViewdeployments/sepolia/WhiteoutResolver.json, Sepolia entry indeployedContracts.tsNo client code references WHITEOUT, so nothing infers it from the ABI. Deploying it stays a separate owner decision.
Permanence tier
Durable (spec/ADR prose). No contract, schema, deploy, or client behavior changes.
Specs / ADRs touched or checked
docs/adr/README.mdamendment pattern; Decision bodies unedited)Test plan
EFSIndexer._isValidAnchorName) checked against the new specs/02 bullet.encodeURIComponentclaim checked with Pythonunicodedataand Node.reads/redirects.ts selectLensRedirect,reads/file.tsper-landed-anchor budget).castagainst publicnode.Agents involved
Fixes #44
Fixes #45
Fixes #46
🤖 Generated with Claude Code