Repository navigation
typetools/checker-framework 3.54.0 release - #2216
Merged
Merged
Conversation
Co-authored-by: Liam Miller-Cushon <cushon@google.com> Co-authored-by: Michael Ernst <mernst@cs.washington.edu> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Suzanne Millstein <smillst@cs.washington.edu>
Converting typetools' two-space formatting to AOSP re-wrapped some comments
mid-paragraph and left a one-word line ("was", "buggy", "postInit()") in
NullnessNoInitVisitor, WholeProgramInferenceJavaParserStorage, and
AnnotatedTypeFactory. Reflow those paragraphs, and tidy the misaligned comment
in CloneOrUpdateTask.update.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…entheses Typetools 3.54.0 writes the expected error key of a test as [key] instead of (key). Parse both in TestDiagnostic: a key in parentheses, or a key that is the whole text in square brackets, loses its delimiters, and the two forms are equal; the delimiters that were written are kept for toString. Other bracketed text, such as javac's [unchecked] prefix, is not taken as a key. Tests written either way now work, which avoids converting 1,314 test files and the harness rework of typetools 3.54.0 for now. New unit tests and BracketErrorKeys.java, which fails without the change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…AnnotationOrWritten Typetools 3.54.0 changed canonicalAnnotation() to return its argument when it is not an alias, which is what canonicalAnnotationOrWritten() did. That method was never released, so remove it and use canonicalAnnotation() at its call sites. asSupportedQualifier() now checks that the canonical form is supported, as its Javadoc says, and the one caller that tested the result for null (the binary stub differential check) compares it with its argument. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ecker accepts The typecheck job runs the Interning Checker on the framework, which rejected the == comparison of two AnnotationMirrors in BinaryStubDiffChecker. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The import added typetools' Claude Code settings. The file is not valid JSON (a trailing comma), enables a Rust analyzer plugin, and allows ./x.py, the Rust compiler's build script, none of which applies to this repository. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
wmdietl
force-pushed
the
typetools-3.54.0-fixes
branch
from
October 4, 2026 05:30
c27b846 to
928eb95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second step of the typetools 3.54.0 import (merge without squashing).
was,buggy,postInit()), e.g. inNullnessNoInitVisitor,WholeProgramInferenceJavaParserStorageandAnnotatedTypeFactory. I scanned every comment paragraph touched by the import for such widows and reflowed them (4 paragraphs), and tidied a misaligned comment inCloneOrUpdateTask. Remaining over-long comment lines are URLs.canonicalAnnotation()returning non-null versus ourcanonicalAnnotationOrWrittendesign; (3) the newprefer.mapsuggestion of the Optional Checker; (4) ajdk-21counterpart of the JDK changes.Companion branches with the same name for CI pairing: eisop/jdk
typetools-3.54.0-fixes(same as eisop/jdk#163).