Repository navigation
Conversation
The generator had no tests, so the CI build only checked that it compiles. Its helpers that do not need the network -- the date formatting, the conversion of the release-shipped page into a Jekyll page, the lookup of the packaged templates, and the filling in of the Annotation File Utilities placeholders -- could regress unnoticed until a scheduled publish ran against the live site. Add JUnit 5 and tests for those helpers. One test checks that the version marker that the Checker Framework release scripts read from the site survives the conversion of the shipped page. Surefire is pinned so that Renovate keeps it up to date. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. The generator has no tests; the CI build (
mvn -B package) only checks that it compiles. Its network-free helpers can regress unnoticed until a scheduled publish runs against the live site.Fix. Add JUnit 5 (test scope) and pin
maven-surefire-plugin, plusEisopSiteGeneratorTestcovering:getReadableDateon GitHub timestamps;themeShippedPage: keeps only the body (case-insensitive tags), handles a page without<body>, and keeps the<!-- checker-framework-zip-version -->marker that the Checker Framework release scripts (release_utils.current_distribution_by_website) read from https://eisop.github.io/cf;readTemplate: both templates are packaged, a missing one is anIOException;substituteAfuPlaceholders: fillscf/index.mdand everycf/<release>/index.md, leaves other files alone, is idempotent, and tolerates missing pages.No change to the generator itself. The asset-name matching added in #112 (
findZipAsset) is not covered here, to keep this PR independent of #112; a test for it can be added there or after it is merged.Testing.
mvn -B verifywith JDK 21: 8 tests pass; spotless and sortpom leave the tree unchanged.