Repository navigation
Conversation
When the release zip or its checker-javadoc.jar could not be extracted, the generator printed the ZipException and carried on. For the release zip, it then moved the zip into cf/ and failed on the missing directory with an unrelated FileNotFoundException; locally the zip in cf/ marks the release as downloaded, so later runs skip it and never create its page. For the Javadoc, it published the release without its API documentation. Let the ZipException propagate, before the zip is moved into cf/ in the first case, and close the zip files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. In
main, aZipExceptionfrom extracting the release zip orchecker/dist/checker-javadoc.jaris printed and ignored.cf/and fails on the missing directory with an unrelatedFileNotFoundException. In a local run, the zip left incf/counts as "already downloaded", so later runs skip that release and never create its page. (In the workflow the failed run commits nothing.)gh-pages, it is never retried.Fix. Let the
ZipException(anIOException) propagate; for the release zip this happens before the zip is moved intocf/. The zip files are closed with try-with-resources, and an encrypted zip is reported as anIOExceptionnaming the file.The AFU extraction is changed separately in #115; this PR does not touch it. Test merges with #112 and #115 are clean.
Testing.
mvn package.--only-latest --local-releasewith a truncated zip now stops withZipException: Zip headers not foundand leavescf/empty; with the realchecker-framework-3.49.5-eisop1.zipthe run completes andcf/api/checker-javadoc/is populated.