Repository navigation
Conversation
index.md, 404.html and _config.yml are edited on master, but the publish workflow only regenerates and commits afu/ and cf/ on gh-pages, and the manual instructions in the README do the same. Edits to these files have therefore never reached the site: the live home page lacks the Contributors section and still links the live demo over http, and the live 404 page lacks the redirects for /cf/manual and /afu without a trailing slash. Copy the three files from the master checkout into the gh-pages checkout before staging, and stage them. Update the README to do the same and to say that a change to them is published by a manual run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem.
index.md,404.htmland_config.ymlare maintained onmaster, butpublish-website.ymlonly regenerates and stagesafu/andcf/in thegh-pagescheckout, and the README's manual procedure does the same. Edits to those files never reach the site. Currently on https://eisop.github.io/:http://(changed tohttps://in Deep repository review: modern APIs, style cleanup, and documentation fixes #110);404.htmllacks the redirects for/cf/manualand/afuwithout a trailing slash (added in Deep repository review: modern APIs, style cleanup, and documentation fixes #110).(
git diff origin/gh-pages origin/master -- index.md 404.htmlshows the differences;_config.ymlis currently identical.)Fix. In the publish job, copy the three files from the
generator(master) checkout into thesitecheckout and stage them along withafuandcf. The README's manual procedure gets the matchinggit checkout master -- ...andgit add, and both the README and the workflow header say that the scheduled run publishes only on a new release, so a change to these pages needs a manual run.Testing. YAML parses; a test merge with #112 (which changes the check job and the top of the README) is clean. The publish path itself can only be exercised by a manual (dry-run) dispatch of the workflow after merging; its run summary will then list
index.mdand404.htmlas modified.