Repository navigation
Use the Markdown title for inline image title attributes - #4667
Closed
shainaraskas wants to merge 1 commit into
Closed
shainaraskas wants to merge 1 commit into
shainaraskas wants to merge 1 commit into
Conversation
The inline image renderer wrote the title attribute from the alt text and never read the Markdown title, so an explicit title was always dropped. Use the Markdown title when provided and fall back to the alt text. Fixes #3045 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
titleattribute and the alt text asalt. If no title is given, the alt text is used for both, as before.docs/syntax/images.mdand the affected test expectations.Fixes #3045
Why
#1656 made alt text always override the Markdown title for inline images, on the basis that most titles in migrated content weren't useful. That drops titles that authors write on purpose. For example, the Elasticsearch enrich settings page uses
, and the tooltip rendered "logo cloud" instead. This change reverses that decision. An explicit title is used, and alt is the fallback.🤖 Generated with Claude Code