Repository navigation
Get the build green: format CdnChangelogEntryFetcherTests, fix two bundle tests - #4680
Merged
Merged
Conversation
`curb check` reports this file as unformatted on `main`, so the pre-commit hook fails for any commit on a branch that merges `main`. The change inlines two raw-string `Json(...)` arguments and touches no test logic. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![infra-vault-gh-plugin-prod[bot]](https://avatars.githubusercontent.com/u/6764390?s=60&v=4){kind=small}
akira28
approved these changes
Nov 4, 2026
Contributor
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/4680/ |
Bundles now land in a subdirectory named after the product, but two `BundleOutputConventionTests` still looked for the file in the changelog directory itself. Both failed on `main` and on every pull request. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Mpdreamz
changed the title
CdnChangelogEntryFetcherTests the way curb expectsCdnChangelogEntryFetcherTests, fix two bundle tests
akira28
added a commit
that referenced
this pull request
Nov 4, 2026
The only conflict was .gitignore. This branch no longer changes it, since received snapshots go to .artifacts, which is already ignored, so the file is taken from main as it is. Main's latest commit, which adds an unformatted CdnChangelogEntryFetcherTests.cs that fails the lint hook until #4680 lands, is left out of this merge. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curb checkreports one unformatted file onmain, and twoBundleOutputConventionTestsfail on everybuildjob. This formats the file and fixes the two tests.Affects: Internals only
Prompt summary: Clear the open pull request queue. Merging
maininto several branches exposed formatting drift that blocks every local commit, so format the one file that causes it. Thebuild (macos-latest)andbuild (ubuntu-latest)checks then failed on two tests unrelated to that file, so fix those too.Why
#4120 passed
linton 28 October. Its last CI run predates the curb setup now onmain, so nothing re-checked the file after the merge. Thedotnet-lintpre-commit task runscurb checkon the whole repository, so one unformatted file fails every commit.#4221 moved bundle output into a per-product subdirectory. Two tests added in #4222 still expect the file in the changelog directory itself, so
Elastic.Changelog.Testsfails.What
Two raw-string arguments
Two
Json(...)calls inCdnChangelogEntryFetcherTestsnow keep their raw-string JSON on the same line as the call. The test logic and the JSON bodies are unchanged.Two stale path assertions
OutputPatternOnAnotherProfile_WarnsAndDoesNotBlockandProfileWithOutputPattern_WarnsAndBundlesByConventionnow look forelasticsearch/elasticsearch-9.3.0.yaml. The product code is unchanged.Verify
🤖 Generated with Claude Code