Repository navigation
Update the search operation snapshot for the popover change - #4683
Merged
Merged
Conversation
![infra-vault-gh-plugin-prod[bot]](https://avatars.githubusercontent.com/u/6764390?s=60&v=4){kind=small}
akira28
approved these changes
Nov 4, 2026
Contributor
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/4683/ |
Member
Author
akira28
added a commit
that referenced
this pull request
Nov 4, 2026
The operation page snapshot included the data payload of its applicability popovers, which comes from the applicability feature and not from the heading structure the test is about. A change to the popover text in #4311 therefore failed the test and turned main red until #4683 updated the snapshot. The test now removes the popover-data attribute. The snapshot differs only in those two attributes. With the same one-word change to the popover text, the old test failed and the narrowed one passes, and a change to a heading in the page still fails it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
akira28
added a commit
that referenced
this pull request
Nov 4, 2026
* Snapshot the response block rendering tests Three tests in ResponsesBlockRenderingTests asserted on 37 substrings of the rendered response block. Each now compares the block to a snapshot and keeps the one or two assertions that state what the test protects. Before the assertions were deleted, each of the 37 was evaluated against the new output and all of them held. Three deliberate markup changes in the Razor partials each failed the converted tests. The block is a component fragment, so the snapshots hold no page chrome and stay small. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * Leave the applicability popover data out of the operation page snapshot The operation page snapshot included the data payload of its applicability popovers, which comes from the applicability feature and not from the heading structure the test is about. A change to the popover text in #4311 therefore failed the test and turned main red until #4683 updated the snapshot. The test now removes the popover-data attribute. The snapshot differs only in those two attributes. With the same one-word change to the popover text, the old test failed and the narrowed one passes, and a change to a heading in the page still fails it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshes one API Explorer snapshot so
Elastic.ApiExplorer.Testspasses on main again.Affects: Internals only
Why
#4311 sets
additionalInfotonullin the applies-to popover when all lifecycles are negative. The snapshot added in #4654 still holds the old deployment text, soRender_SearchOperation_UsesOneH1ThenH2SectionsAndH3Nestedfails on CI.What
Snapshot
The verified HTML for the search operation now has
"additionalInfo":nullin the popover data. No product code changes.Verify
dotnet test --project tests/Elastic.ApiExplorer.Tests🤖 Generated with Claude Code