chore(ep-commerce): repoint the pins at the published 0.4.0 - #456
Merged
Conversation
canvas-packages and loader-bundle-env still pinned ^0.2.0 and the example app ^0.3.0, so Studio served components publishing the pre-ADR-0002 shape. Moving them is what lets migration 259 (#442) run without repointing bindings ahead of the components. Each directory carries its own yarn.lock, so the resolutions move with the pins; @plasmicpkgs/commerce drops out of all three trees, which is ADR-0002 landing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
platform/canvas-packagesandplatform/loader-bundle-envstill pinned^0.2.0, and the example app^0.3.0, so Studio served components publishing the pre-ADR-0002 shape. This is step 2 of the deploy order on #442: publish 0.4.0 → move both pins → deploy 259.Each directory carries its own
yarn.lock, so the resolutions move with the pins rather than going stale.@plasmicpkgs/commercedrops out of all three trees, which is ADR-0002 landing — 0.4.0 no longer depends on the Shopify-lineage normalization.Verified against the published tarball, not a local build: the example app's
node_modulesnow holds 0.4.0 from npm, and the lockfile shasums match the pre-publish dry run. A bundle variation switch on/bundle/[slug]reports one selection rather than two, at the child's price, with no render-phase warnings.@plasmicpkgs/commerceremains a direct dependency of the example app with no imports left in its source. Left alone here; worth removing separately.