Repository navigation
Check group access before showing entries and serving entry files - #164
Merged
Merged
Conversation
Follow-up to #163. In separate groups mode, report.php showed all entries to a grader who is in no group and cannot access all groups, and journal_pluginfile served entry and feedback files of any student to any grader. Both now respect group visibility.
adrian-sarmas
force-pushed
the
followup-163-group-read-access
branch
from
October 11, 2026 18:28
3f8c0aa to
0c0c6f5
Compare
Setting separate groups on the shared background journal changed the entry count shown to the teacher on the journals list page and broke an existing scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #163, which fixed the write side.
In separate groups mode:
moodle/site:accessallgroups. They now get the core "need to be part of a
group" notice instead.
grader. It now checks groups_user_groups_visible.
Adds a unit test for journal_pluginfile and a Behat scenario for the report page.