Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
About 1 in 10 Authorize clicks in agent-first onboarding never ends with the CLI confirming the key, and about 7% of people hit it on their first try. When it happens, the CLI knows what went wrong, but it can't tell us: the sign-in never got a token, so there's no API call, and the approval page only sees the click. From the page's side, the biggest group (about 45%) looks like "the browser never reached the CLI", which could be a CLI the agent already stopped, a timeout, a port problem or something else.
This makes the CLI say how each sign-in ended, the next time it can:
timed-out,declined,port-busy,replaced,restarted,stopped(the worker went away before replying, before or after the browser step:stopped-after),exchange-connect/-timeout/-refused/-server/-other(the token exchange now names its failure), and for a sign-in that worked, how the key hand-off went (created,no-key,clipboard-error,wrong-account,unverified, ...).cli_prev=<outcome>andcli_prev_id, the first 16 hex characters of the SHA-256 of the earlier sign-in'sstate. The page can compute the same hash from its own link, so a report can be matched to the click it explains; the state itself never leaves the machine.onboardrequests carry it too, as asignin/<outcome>User-Agent tag. About 42% of failed clicks are followed by a new approval page within a day and 56% by a signed-in CLI call (connect, check or test), 74% by one or the other, so between the two most failures get explained, including people who give up and add a key by hand.cli_agenton the approval link andagent/<name>on every request.claude-code,claude-desktop,cursor,codex,gemini-cliorvscode. Claude Code'sCLAUDECODEandCLAUDE_CODE_ENTRYPOINTare checked first-hand; the others come from each tool's docs and are worth confirming in the eval harness.All of it follows the 1.8.0 telemetry switch:
--telemetry off,ELEVENLABS_TELEMETRY=offorDO_NOT_TRACK=1turns it off, and only fixed words are sent. Outcomes older than a day aren't reported. The README and--telemetryhelp say what's sent.The API and the approval page need to keep the new values: the page in elevenlabs/xi#58352, the User-Agent tags in a small change next to #59230's tag parsing. Nothing breaks without them; the values are just dropped.
No version bump: this can go out with the next release.
Testing
cargo test: all 3,342 tests pass on macOS, including the onboard integration tests. New tests:sign-in-errororother, and every label fits the API's tag pattern ([a-z-]{1,16});stopped/stopped-afterwhen the worker left none, and nothing while one is running;restartedwhen this command stopped it), and a tampered file reports nothing;CLAUDECODE=1,onboard connect --no-browserprinted an approval link withcli_agent=claude-code,cli_prev=timed-outandcli_prev_id=ba7816bf8f01cfea(the first 8 bytes of SHA-256 of that sign-in'sstate).