Repository navigation
docs(patterns): add bunFullstack: true to fullstack dev server examples - #881
bealexaraujo wants to merge 2 commits into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. WalkthroughThe fullstack dev server guide now explains when to use ChangesFullstack dev server documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Other · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The updated examples match the supported fullstack setup, and no merge-blocking issue is established. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Await the hooks, let pages take flight~ Comment |
The Fullstack Dev Server guide is missing
bunFullstack: truefrom thestaticPlugin()examples, which causes JSX/TSX files to be served asplain text instead of being compiled. Developers following the guide get:
This is because
bunFullstackdefaults tofalsein@elysia/static(confirmed in
src/index.ts), so Bun's bundler is never activated unlessexplicitly enabled.
This PR:
bunFullstack: trueto the initial setup examplebunFullstack: trueto the custom prefix path exampleawaitANDbunFullstack: trueare required — and what happens if
bunFullstackis omittedFixes: #859
Summary by CodeRabbit