Repository navigation
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/8650-p120-1 View snapshot changes at kitdiff |
This was referenced Sep 30, 2026
Contributor
Author
|
I've been testing this extensively for a week, and it works great for me! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on the Windows redraw-ledger approach proposed by
MattReid87to prevent deferred viewports from stopping repainting when the root viewport has focus.On Windows, redraw requests are tracked in order. When a window receives a
RedrawRequestedevent, it is painted first, followed by older outstanding requests in order. Direct paints are limited by a 5 ms soft time budget per event; requests not reached within that budget remain in the ledger. A paint that has already started may exceed the budget.This keeps the ledger approach while limiting how long one redraw event spends catching up on deferred viewports. The change is Windows-only.
This PR supersedes #8467.
deferred viewportdoes not redraw when clickingROOT viewport(Windows) #8351