Remove usage of shared.EMCC et al from test code. NFC - #27673
Merged
Conversation
sbc100
changed the title
shared.EMCC et al from test code. NFC
sbc100
force-pushed
the
avoid_shared_emcc
branch
from
September 4, 2026 23:48
1479b12 to
eb20461
Compare
Move tool paths (such as `EMCC`, `LLVM_COV`, `LLVM_PROFDATA`, and `WASM_LD`) from `tools/shared.py` to `test/common.py` or `tools/building.py`. Also, remove the dead `_is_ar_cache` from `tools/building.py`. Part of the effort to decouple test code from compiler internals. See: emscripten-core#27666
sbc100
force-pushed
the
avoid_shared_emcc
branch
from
September 5, 2026 00:14
eb20461 to
4ce8e65
Compare
dschuff
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move tool paths (such as
EMCC,LLVM_COV,LLVM_PROFDATA, andWASM_LD) fromtools/shared.pytotest/common.pyortools/building.py.Also, remove the dead
_is_ar_cachefromtools/building.py.Part of the effort to decouple test code from compiler internals.
See: #27666