NXT-10275: Added support for prerendering Popup/PopupTabLayout - #385
Open
daniel-stoian-lgp wants to merge 10 commits into
Open
NXT-10275: Added support for prerendering Popup/PopupTabLayout#385daniel-stoian-lgp wants to merge 10 commits into
daniel-stoian-lgp wants to merge 10 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #385 +/- ##
===========================================
+ Coverage 82.54% 82.67% +0.13%
===========================================
Files 153 153
Lines 7579 7580 +1
Branches 2298 2298
===========================================
+ Hits 6256 6267 +11
+ Misses 1029 1021 -8
+ Partials 294 292 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alexandrumorariu
left a comment
Contributor
There was a problem hiding this comment.
Do not forget to change the branch back to develop for ci-reusable.yml before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Builds on the Enact ui/FloatingLayer prerender change to make the Popup family (specifically PopupTabLayout) renderable during a prerender pass. The first render needed two phases before, so the popup was missing from prerendered HTML (WRQ-28907).
Depends on the Enact PR enactjs/enact#3437 (ui/FloatingLayer prerender prop). Merge/publish that first.
Resolution
Popup: accept and forward prerender to FloatingLayer. Also fixes spotlight focus on a prerendered launch: with prerender, the content mounts inline before the tab layout's spotlight config is ready, so the early mount-effect spot landed on the wrong element (panel content) and was restored after relocation. The early spot is now skipped for the prerender path, so focus lands via onOpen after relocation.
PopupTabLayout: route prerender through to Popup (stripped in optimized mode).
TabLayout/RefocusDecorator: guard the orientation initializer with isWindowReady() so it doesn't read window during the prerender pass (previously threw ReferenceError: window is not defined, blocking both the prerender and optimized paths).
Tests: added unit tests and ui tests for prerender scenario
Sample: samples/qa-popuptablayout-prerender demonstrating a 4-tab PopupTabLayout prerendered on launch.
Additional Considerations
Links
NXT-10275
Comments
Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)