Fix Worker redirects breaking OAuth login - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #5 rebuilt upstream requests with the default redirect mode (
follow), causing the Worker to follow OAuth callback redirects itself. The browser received the final response instead of the redirect and its authentication cookies, breaking SSO through Linkup.Set the upstream redirect mode to
Manualwhile preserving streamed bodies. Add a Worker integration test that verifies the 303 status, Location header, and both Set-Cookie headers reach the client. Update Wrangler entry points and CI placeholder artifacts to the worker-build 0.8 output paths so CI runs the current Worker.Validation:
cargo test -p linkup-server-tests -- --include-ignored).worker-build --release,cargo fmt --all --check, andgit diff --checkpassed.The Worker needs redeploying for the fix to take effect; live Google SSO has not been retested.