Skip to content

Remove yaml cmake workaround #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvandyk merged 1 commit into from
Sep 17, 2026
Merged

Remove yaml cmake workaround #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manylinux_2_34/aarch64/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ RUN mkdir -p /yaml/build \
&& tar zxf yaml-cpp-0.9.0.tar.gz \
&& pushd build \
&& export CXXFLAGS="-O2 -g -fPIC -DPIC" \
&& cmake -DCMAKE_INSTALL_PREFIX:PATH=/usr -DBUILD_SHARED_LIBS=on -DCMAKE_POLICY_VERSION_MINIMUM=3.5 ../yaml-cpp-yaml-cpp-0.9.0 \
&& cmake -DCMAKE_INSTALL_PREFIX:PATH=/usr -DBUILD_SHARED_LIBS=on ../yaml-cpp-yaml-cpp-0.9.0 \
&& make -j4 \
&& make install \
&& popd \
Expand Down
3 changes: 1 addition & 2 deletions manylinux_2_34/x86_64/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,13 @@ RUN yum -y install chrpath cmake git libtool \
&& rm -rf /var/cache/yum

# installation destination of the pkg-config file is hardcoded to /usr/lib/pkgconfig
# - using -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to avoid https://github.com/jbeder/yaml-cpp/issues/1352
RUN mkdir -p /yaml/build \
&& pushd /yaml \
&& curl -L -O https://github.com/jbeder/yaml-cpp/archive/refs/tags/yaml-cpp-0.9.0.tar.gz \
&& tar zxf yaml-cpp-0.9.0.tar.gz \
&& pushd build \
&& export CXXFLAGS="-O2 -g -march=x86-64 -fPIC -DPIC" \
&& cmake -DCMAKE_INSTALL_PREFIX:PATH=/usr -DBUILD_SHARED_LIBS=on -DCMAKE_POLICY_VERSION_MINIMUM=3.5 ../yaml-cpp-yaml-cpp-0.9.0 \
&& cmake -DCMAKE_INSTALL_PREFIX:PATH=/usr -DBUILD_SHARED_LIBS=on ../yaml-cpp-yaml-cpp-0.9.0 \
&& make -j2 \
&& make install \
&& popd \
Expand Down