Split __str__ and __repr__ on Timecode#73
Open
nickswalker wants to merge 1 commit into
Open
Conversation
__repr__ now returns a Python-eval-able form; __str__ returns the timecode string (the previous __repr__ behavior). Adds test_repr_parse to verify round-trip fidelity. Co-authored-by: cubicibo <55701024+cubicibo@users.noreply.github.com>
nickswalker
force-pushed
the
str-repr-split
branch
from
9490c44 to
cf7b6e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cubicibo proposed some good changes in #69. I am chunking out some of the non-core parts of that PR in the hopes that it'd be easier to review.
__repr__now returns a Python-eval-able form;__str__returns the timecode string (the previous__repr__behavior). Addstest_repr_parseto verify round-trip fidelity.This is what the
__repr__docs say is expected: