Repository navigation
fix(controller): use reasonable polling interval instead of time.Nanosecond - #1297
Open
AruneshDwivedi wants to merge 1 commit into
Open
AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
…second The wait.PollImmediate call was using time.Nanosecond as the interval, which causes continuous polling without any delay. This results in: - Excessive CPU usage - Unnecessary load on the Kubernetes API server - Potential rate limiting issues Changed to time.Second for a reasonable polling interval that still responds quickly to pod state changes while being gentle on resources. Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
AruneshDwivedi
requested review from
ashnamehrotra,
pmengelbert and
sozercan
as code owners
October 4, 2026 02:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wait.PollImmediate call in the imagejob controller uses time.Nanosecond as the polling interval, causing continuous polling without any delay between attempts. This results in excessive CPU usage and unnecessary load on the Kubernetes API server.
Fix: Change the interval to time.Second for a reasonable polling frequency.
Signed-off-by: Arunesh Dwivedi arunesh.devops@gmail.com