Skip to content

fix(controller): use reasonable polling interval instead of time.Nanosecond #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AruneshDwivedi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(controller): use reasonable polling interval instead of time.Nanosecond #1298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controllers/imagejob/imagejob_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ func (r *Reconciler) handleNewJob(ctx context.Context, imageJob *eraserv1.ImageJ

for _, namespacedName := range namespacedNames {
//nolint:staticcheck // SA1019: TODO: Replace with PollUntilContextTimeout in future refactor
if err := wait.PollImmediate(time.Nanosecond, time.Minute*5, r.isPodReady(ctx, namespacedName)); err != nil {
if err := wait.PollImmediate(time.Second, time.Minute*5, r.isPodReady(ctx, namespacedName)); err != nil {
log.Error(err, "timed out waiting for pod to leave pending state", "pod NamespacedName", namespacedName)
}
}
Expand Down