Repository navigation
Fix bmo show cycle issues - #17
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Overlapping-cycle output still omits dependency edges, and the repair hint does not reliably resolve duplicated or multiple cycles.
Review effort: Balanced
Findings: 3
Open (4)
What changed in this PR
Improves cycle diagnostics and relation displays across the CLI and web UI.
Changes:
- Adds SCC-based cycle grouping and remediation hints.
- Normalizes relation views and dependency graph output.
- Adds version flags, bumps to 0.9.0, and expands tests.
| File | Description |
|---|---|
Cargo.toml |
Bumps package version. |
Cargo.lock |
Updates locked package version. |
docs/commands.md |
Documents version flags and graph output. |
src/cli/issue/graph.rs |
Normalizes and groups blocking relations. |
src/cli/mod.rs |
Adds top-level version flags. |
src/model/relation.rs |
Adds endpoint-relative relation views. |
src/output/human.rs |
Corrects relation rendering direction. |
src/planner/topo.rs |
Adds detailed cycle detection and messages. |
src/web/handlers.rs |
Supplies normalized relations to templates. |
src/web/templates/issue.html |
Links to the opposite relation endpoint. |
tests/cli.rs |
Tests version flag behavior. |
tests/cycle_detection.rs |
Tests cycle diagnostics end-to-end. |
tests/graph.rs |
Tests graph relation semantics. |
tests/show_relations.rs |
Tests CLI relation rendering. |
tests/web.rs |
Tests web relation rendering. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



We aren't clearly declaring what the dependencies are when we show cycles: it was easier to find a cycle by simply recording all the nodes seen along the way and then printing them as a list. However, this is confusing: what are the edges?
This PR attempts to improve the situation by including more information about these cycles and how to repair them.