Repository navigation
fix(api): restrict survey triage to reviewer groups by confidentiality - #1111
Merged
Merged
Conversation
Triage endpoints now require membership in Security Reviewers (non-confidential responses) or Confidential Project Reviewers (confidential responses); ownership and the row ACL grant no triage access. Denial is 404; the list is scoped via an is_confidential store filter and is empty for non-reviewers. Fixes #1100 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015szS68rpMLaq712AFsbMfr
Intake PATCH may now set status only to draft or submitted, closing a bypass of the triage reviewer restriction. Also resolve membership once in the triage list scope, add triage metadata positive-path tests, and refresh SEM markers. Fixes #1100 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015szS68rpMLaq712AFsbMfr
Refs #1100 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The submitter now gets 404 on triage per-id routes and a 400 when PATCHing intake status to ready_for_review. Security Reviewers and Confidential Project Reviewers members triage via the group-membership path. Refs #1100 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015szS68rpMLaq712AFsbMfr
Refs #1100 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015szS68rpMLaq712AFsbMfr
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015szS68rpMLaq712AFsbMfr
…ding Triage endpoints now admit only reviewer-group members, so seeding a triage note as charlie (admin, not a reviewer) returned 404. Refs #1100 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015szS68rpMLaq712AFsbMfr
ericfitz
force-pushed
the
fix/1100-triage-reviewer-authz
branch
from
October 18, 2026 03:38
90b1ddf to
edb84e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/triage/survey_responses/*, including metadata and triage notes) are open only to Security Reviewers for non-confidential responses and to Confidential Project Reviewers for confidential ones. Ownership and the row ACL grant no triage access. This is a human decision; see the ADRdocs/superpowers/specs/2026-10-17-adr-triage-access-by-reviewer-group.md.is_confidential, so a non-reviewer gets an empty 200.PATCH /intake/survey_responses/{id}may set status only todraftorsubmitted; any other value returns 400. This closes a path where a submitter could approve their own response (human decision, confirmed 2026-10-17).Notes
ResolveMembershipContextpath, which I checked by reading the code; no test covers it.is_confidentialquery parameter).Test plan
make verifyFixes #1100
🤖 Generated with Claude Code
https://claude.ai/code/session_015szS68rpMLaq712AFsbMfr