Repository navigation
fix(auth): rate limit GET /oauth2/step_up - #1112
Merged
Merged
Conversation
Add /oauth2/step_up to the centralized isAuthFlowEndpoint set so the auth-flow limiter (session/IP/login_hint scopes) covers it. The set is consulted by AuthFlowRateLimitMiddleware and by the per-user RateLimitMiddleware skip, so there is one list. The per-user limiter keys on "user_id", which the JWT middleware never sets on REST routes; that is tracked separately and not changed here. Fixes #1101 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015szS68rpMLaq712AFsbMfr
Refs #1101 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015szS68rpMLaq712AFsbMfr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/oauth2/step_upto the sharedisAuthFlowEndpointlist, so the auth-flow limiter (session, IP and login_hint scopes) covers it.Test plan
api/rate_limit_middleware_test.gofailed before the fix and passes after itmake verifyFixes #1101
🤖 Generated with Claude Code
https://claude.ai/code/session_015szS68rpMLaq712AFsbMfr